Skip to content

Add 'By ADS' to logos when in Astrophysics, heliophysic, planetary mode#735

Merged
shinyichen merged 1 commit intoadsabs:masterfrom
shinyichen:SCIX-657-by-ads-logo
Dec 16, 2025
Merged

Add 'By ADS' to logos when in Astrophysics, heliophysic, planetary mode#735
shinyichen merged 1 commit intoadsabs:masterfrom
shinyichen:SCIX-657-by-ads-logo

Conversation

@shinyichen
Copy link
Member

Screen.Recording.2025-12-15.at.11.38.28.AM.mov

@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.1%. Comparing base (95059b0) to head (68a7cc0).

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #735     +/-   ##
========================================
+ Coverage    70.1%   70.1%   +0.1%     
========================================
  Files         218     218             
  Lines       24126   24151     +25     
  Branches     1287    1292      +5     
========================================
+ Hits        16896   16917     +21     
- Misses       7195    7199      +4     
  Partials       35      35             
Files with missing lines Coverage Δ
src/components/LandingTabs/LandingTabs.tsx 87.5% <100.0%> (+1.1%) ⬆️
src/components/NavBar/NavBar.tsx 96.8% <100.0%> (+0.9%) ⬆️
src/types.ts 100.0% <100.0%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@thostetler thostetler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@shinyichen shinyichen merged commit a213340 into adsabs:master Dec 16, 2025
4 checks passed
@shinyichen shinyichen deleted the SCIX-657-by-ads-logo branch December 16, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants