SCIX-752: Fix verify middleware crash and implement cross-domain session synchronization#736
Merged
thostetler merged 2 commits intoadsabs:masterfrom Dec 17, 2025
Conversation
…tion Fixed critical bug where users clicking email verification links crashed due to missing session token checks. Implemented proper Sidecar Session pattern for seamless cross-domain session sharing between legacy BBB and Next.js apps. - Added defensive null checks in verifyMiddleware to handle missing session.token - Implemented cookie synchronization with domain stripping and SameSite=Lax per spec - Fixed hash encoding to use proper hex format instead of comma-separated decimals - Fixed apiCookieHash presence check to match empty string return value - Migrated middleware to use edge-compatible error handler - Added comprehensive documentation for Sidecar Session architecture Note: Hash encoding fix will invalidate existing sessions requiring users to re-authenticate.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #736 +/- ##
========================================
- Coverage 69.9% 69.7% -0.1%
========================================
Files 220 219 -1
Lines 24478 24509 +31
Branches 1304 1303 -1
========================================
- Hits 17086 17066 -20
- Misses 7357 7408 +51
Partials 35 35
🚀 New features to boost your workflow:
|
shinyichen
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users clicking email verification links crashed with "Cannot read property 'access_token' of undefined" because the verify middleware tried to access
session.token.access_tokenwithout checking if the token existed.Cookie synchronization now properly handles cross-domain session sharing between BBB and Scix:
Deployment Note