Skip to content

Improve middleware test coverage#737

Merged
thostetler merged 1 commit intoadsabs:masterfrom
thostetler:add-middleware-tests
Dec 19, 2025
Merged

Improve middleware test coverage#737
thostetler merged 1 commit intoadsabs:masterfrom
thostetler:add-middleware-tests

Conversation

@thostetler
Copy link
Member

@thostetler thostetler commented Dec 17, 2025

Adds lots of middleware tests
Brings some mock-server based e2e tests back in so we can simplify a CI setup

@thostetler thostetler changed the title fix: resolve type errors in middleware tests Improve middleware test coverage Dec 17, 2025
@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

❌ Patch coverage is 83.67347% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.3%. Comparing base (a4885b7) to head (77ddf63).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/middlewares/initSession.ts 64.3% 4 Missing and 1 partial ⚠️
src/middlewares/verifyMiddleware.ts 88.9% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #737     +/-   ##
========================================
+ Coverage    69.7%   72.3%   +2.7%     
========================================
  Files         221     221             
  Lines       24764   24803     +39     
  Branches     1342    1463    +121     
========================================
+ Hits        17253   17929    +676     
+ Misses       7470    6833    -637     
  Partials       41      41             
Files with missing lines Coverage Δ
src/logger.ts 66.7% <100.0%> (+1.9%) ⬆️
src/middlewares/botCheck.ts 100.0% <100.0%> (+68.2%) ⬆️
src/mocks/handlers.ts 100.0% <100.0%> (ø)
src/middlewares/verifyMiddleware.ts 91.9% <88.9%> (+76.4%) ⬆️
src/middlewares/initSession.ts 90.7% <64.3%> (+59.8%) ⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thostetler thostetler marked this pull request as draft December 18, 2025 17:31
@thostetler thostetler force-pushed the add-middleware-tests branch 3 times, most recently from 241fec2 to f65b094 Compare December 18, 2025 20:52
@thostetler thostetler marked this pull request as ready for review December 18, 2025 21:30
- Bring middleware tests back into the repo
@thostetler thostetler merged commit ad159a6 into adsabs:master Dec 19, 2025
5 checks passed
@thostetler thostetler deleted the add-middleware-tests branch December 19, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants