Skip to content

SCIX-776 fix: hide notification bell functionality for unauthenticated users#762

Merged
thostetler merged 2 commits intoadsabs:masterfrom
thostetler:SCIX-776-notification-bell-button-on
Jan 14, 2026
Merged

SCIX-776 fix: hide notification bell functionality for unauthenticated users#762
thostetler merged 2 commits intoadsabs:masterfrom
thostetler:SCIX-776-notification-bell-button-on

Conversation

@thostetler
Copy link
Member

@thostetler thostetler commented Jan 11, 2026

The notification bell on the search results page was accessible to unauthenticated users, allowing them to attempt creating email notifications without being logged in.

  • Added authentication check for the bell button in ListActions
  • Unauthenticated users now see a gray bell icon with a popover explaining login is required
  • Popover includes links to login and create account pages
  • Extracted NotificationBellButton component for cleaner code organization
  • Added tests for both authenticated and unauthenticated bell button behavior
image

…d users

- Added login-required popover when unauthenticated users click the notification bell
- Extracted NotificationBellButton component for cleaner code organization
- Added tests for authenticated vs unauthenticated bell button behavior
@codecov
Copy link

codecov bot commented Jan 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.8%. Comparing base (9678f94) to head (56f1fe1).
⚠️ Report is 12 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (9678f94) and HEAD (56f1fe1). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (9678f94) HEAD (56f1fe1)
unittests 2 1
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #762      +/-   ##
=========================================
- Coverage    71.8%   60.8%   -11.0%     
=========================================
  Files         217     300      +83     
  Lines       24485   34871   +10386     
  Branches     1402    1486      +84     
=========================================
+ Hits        17575   21192    +3617     
- Misses       6878   13645    +6767     
- Partials       32      34       +2     
Files with missing lines Coverage Δ
src/components/ResultList/ListActions.tsx 78.0% <100.0%> (ø)

... and 102 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thostetler thostetler requested a review from shinyichen January 11, 2026 21:58
@thostetler thostetler marked this pull request as ready for review January 11, 2026 21:58
Copy link
Member

@shinyichen shinyichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I updated the tour related id, because the id of IconButton was getting overwritten by chakra in the popover.

@thostetler thostetler merged commit 14edf58 into adsabs:master Jan 14, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants