SCIX-776 fix: hide notification bell functionality for unauthenticated users#762
Merged
thostetler merged 2 commits intoadsabs:masterfrom Jan 14, 2026
Merged
Conversation
…d users - Added login-required popover when unauthenticated users click the notification bell - Extracted NotificationBellButton component for cleaner code organization - Added tests for authenticated vs unauthenticated bell button behavior
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #762 +/- ##
=========================================
- Coverage 71.8% 60.8% -11.0%
=========================================
Files 217 300 +83
Lines 24485 34871 +10386
Branches 1402 1486 +84
=========================================
+ Hits 17575 21192 +3617
- Misses 6878 13645 +6767
- Partials 32 34 +2
🚀 New features to boost your workflow:
|
shinyichen
approved these changes
Jan 14, 2026
Member
shinyichen
left a comment
There was a problem hiding this comment.
Looks good. I updated the tour related id, because the id of IconButton was getting overwritten by chakra in the popover.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The notification bell on the search results page was accessible to unauthenticated users, allowing them to attempt creating email notifications without being logged in.