SCIX-775 fix: use OR operator for multiple collections in classic form#764
Merged
thostetler merged 1 commit intoadsabs:masterfrom Jan 14, 2026
Merged
Conversation
When selecting multiple collections (e.g., Astronomy and Physics), the query was incorrectly joining them with spaces instead of OR operators, producing `collection:(astronomy physics)` instead of the correct `collection:(astronomy OR physics)`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #764 +/- ##
========================================
- Coverage 71.8% 71.8% -0.0%
========================================
Files 217 217
Lines 24485 24485
Branches 1402 1402
========================================
- Hits 17575 17574 -1
- Misses 6878 6879 +1
Partials 32 32
🚀 New features to boost your workflow:
|
shinyichen
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When selecting multiple collections in the classic form (e.g., Astronomy
and Physics), the query was incorrectly joining them with spaces instead
of OR operators, producing
collection:(astronomy physics)instead ofthe correct
collection:(astronomy OR physics).logicJoin('and')tologicJoin('or')ingetLimit()