Skip to content

SCIX-775 fix: use OR operator for multiple collections in classic form#764

Merged
thostetler merged 1 commit intoadsabs:masterfrom
thostetler:SCIX-775-classic-form-operator-bug
Jan 14, 2026
Merged

SCIX-775 fix: use OR operator for multiple collections in classic form#764
thostetler merged 1 commit intoadsabs:masterfrom
thostetler:SCIX-775-classic-form-operator-bug

Conversation

@thostetler
Copy link
Member

When selecting multiple collections in the classic form (e.g., Astronomy
and Physics), the query was incorrectly joining them with spaces instead
of OR operators, producing collection:(astronomy physics) instead of
the correct collection:(astronomy OR physics).

  • Changed logicJoin('and') to logicJoin('or') in getLimit()
  • Updated test expectations to match correct OR-joined output

When selecting multiple collections (e.g., Astronomy and Physics), the
query was incorrectly joining them with spaces instead of OR operators,
producing `collection:(astronomy physics)` instead of the correct
`collection:(astronomy OR physics)`.
@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.8%. Comparing base (9678f94) to head (e1cf29c).

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #764     +/-   ##
========================================
- Coverage    71.8%   71.8%   -0.0%     
========================================
  Files         217     217             
  Lines       24485   24485             
  Branches     1402    1402             
========================================
- Hits        17575   17574      -1     
- Misses       6878    6879      +1     
  Partials       32      32             
Files with missing lines Coverage Δ
src/components/ClassicForm/helpers.ts 98.3% <100.0%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thostetler thostetler requested a review from shinyichen January 12, 2026 05:17
@thostetler thostetler marked this pull request as ready for review January 12, 2026 05:17
@thostetler thostetler merged commit 8e716dd into adsabs:master Jan 14, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants