Skip to content

Use global settings for toast#768

Merged
shinyichen merged 1 commit intoadsabs:masterfrom
shinyichen:SCIX-324-consistent-toast
Jan 15, 2026
Merged

Use global settings for toast#768
shinyichen merged 1 commit intoadsabs:masterfrom
shinyichen:SCIX-324-consistent-toast

Conversation

@shinyichen
Copy link
Member

Attempt to make toast consistent using global settings.

@shinyichen shinyichen requested a review from thostetler January 14, 2026 21:55
@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

❌ Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.9%. Comparing base (cf445b1) to head (89c2945).

Files with missing lines Patch % Lines
src/components/Orcid/Actions.tsx 0.0% 3 Missing ⚠️
.../components/EmailNotifications/Forms/ArxivForm.tsx 0.0% 1 Missing ⚠️
...mponents/EmailNotifications/Forms/CitationForm.tsx 0.0% 1 Missing ⚠️
...mponents/EmailNotifications/Forms/KeywordsForm.tsx 0.0% 1 Missing ⚠️
.../components/EmailNotifications/Forms/QueryForm.tsx 0.0% 1 Missing ⚠️
src/components/Orcid/AddToOrcidButton.tsx 0.0% 1 Missing ⚠️
src/components/Orcid/BulkClaimMenuItem.tsx 0.0% 1 Missing ⚠️
src/components/Orcid/BulkDeleteMenuItem.tsx 0.0% 1 Missing ⚠️
src/components/Orcid/DeleteFromOrcidButton.tsx 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #768     +/-   ##
========================================
- Coverage    60.9%   60.9%   -0.0%     
========================================
  Files         301     301             
  Lines       35099   35076     -23     
  Branches     1506    1505      -1     
========================================
- Hits        21358   21343     -15     
+ Misses      13707   13699      -8     
  Partials       34      34             
Files with missing lines Coverage Δ
src/components/NavBar/NavMenus.tsx 18.9% <ø> (+0.2%) ⬆️
src/components/Orcid/helpers.ts 32.6% <ø> (-7.0%) ⬇️
src/lib/useSettings.ts 64.0% <100.0%> (-1.9%) ⬇️
.../components/EmailNotifications/Forms/ArxivForm.tsx 13.8% <0.0%> (ø)
...mponents/EmailNotifications/Forms/CitationForm.tsx 11.8% <0.0%> (ø)
...mponents/EmailNotifications/Forms/KeywordsForm.tsx 14.1% <0.0%> (ø)
.../components/EmailNotifications/Forms/QueryForm.tsx 20.0% <0.0%> (ø)
src/components/Orcid/AddToOrcidButton.tsx 23.7% <0.0%> (-1.3%) ⬇️
src/components/Orcid/BulkClaimMenuItem.tsx 18.5% <0.0%> (-0.3%) ⬇️
src/components/Orcid/BulkDeleteMenuItem.tsx 24.9% <0.0%> (-0.3%) ⬇️
... and 2 more
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@thostetler thostetler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't fully test/see all these toasts.
But the changes look good to me!

@shinyichen shinyichen merged commit 8deae84 into adsabs:master Jan 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants