SCIX-778 feat(classic-form): extract collection and property into query filters#772
Merged
thostetler merged 7 commits intoadsabs:masterfrom Jan 21, 2026
Merged
Conversation
Add interface for structured query params with filter query support. This type will be used as the return type for the new getSearchQueryParams function that extracts collection and property into separate fq params.
…raction Add getSearchQueryParams function that returns structured query params instead of a URL string. This extracts collection and property choices into separate fq_database and fq_property filter params, moving them out of the main q param. - Add getDatabaseFilter helper for database: (x OR y) filters - Add getPropertyFilter helper for property: (x AND y) filters - Add makeFQHeader helper for Solr filter query headers - Update test imports for new function
…ters to fq params getSearchQuery now delegates to getSearchQueryParams, eliminating duplicated code. This changes the default behavior so that collection and property filters are extracted to fq_database and fq_property params instead of being embedded in the q parameter.
Export getSearchQueryParams, getDatabaseFilter, getPropertyFilter and IClassicFormQueryParams from the barrel file using explicit named exports.
Added index signature to IClassicFormQueryParams for compatibility with SafeSearchUrlParams, and added explicit return type annotation to useMemo in CurrentQuery component to fix implicit any[] type inference.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #772 +/- ##
========================================
+ Coverage 60.9% 61.0% +0.1%
========================================
Files 301 301
Lines 35040 35128 +88
Branches 1500 1505 +5
========================================
+ Hits 21320 21408 +88
Misses 13686 13686
Partials 34 34
🚀 New features to boost your workflow:
|
shinyichen
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Classic form now generates fq_database and fq_property filter params instead of embedding collection and property in the q param, matching legacy ADS URL format.