SCIX-794, SCIX-774: Add discipline routes, fix legacy referrer, rename General Science#773
Merged
thostetler merged 9 commits intoadsabs:masterfrom Jan 21, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #773 +/- ##
========================================
+ Coverage 60.9% 60.9% +0.1%
========================================
Files 301 301
Lines 35040 35081 +41
Branches 1500 1507 +7
========================================
+ Hits 21320 21349 +29
- Misses 13686 13698 +12
Partials 34 34
🚀 New features to boost your workflow:
|
The /onboard route was a legacy redirect that captured the referrer, logged to Sentry, and redirected to home. It served no real purpose - essentially a no-op redirect. Now that discipline-specific routes (/astrophysics, /heliophysics, etc.) and legacy referrer handling in middleware are in place, this route is obsolete. Also removes the noindex header configuration for /onboard.
…ling - Add mapPathToDisciplineParam tests covering valid paths, invalid paths, and case-insensitivity - Add forceMode handling tests verifying precedence over d param and legacy referrer detection
e796903 to
15d8f4f
Compare
shinyichen
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the deprecated /onboard route with discipline-specific routes (/astrophysics, /heliophysics, /planetary, /earth, /biophysical) that immediately set the selected discipline and redirect to home.
Also fixes the bug where users arriving from the legacy ADS app (ui.adsabs.harvard.edu) don't immediately see the Astrophysics discipline selected - it previously only switched on the next search.
Additionally renames "General Science" to "No preferred discipline" (SCIX-774).