SCIX-817 feat(search-facet): filter collections facet to exclude astrophysics, planetary, and heliophysics#777
Merged
thostetler merged 2 commits intoadsabs:masterfrom Jan 24, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #777 +/- ##
========================================
+ Coverage 61.0% 61.0% +0.1%
========================================
Files 301 301
Lines 35169 35176 +7
Branches 1515 1515
========================================
+ Hits 21438 21445 +7
Misses 13697 13697
Partials 34 34
🚀 New features to boost your workflow:
|
thostetler
changed the title
…cy databases The API returns 7 database values but we only want to display 4 in the Collections facet UI. - Add filter property to collections config to include only astronomy, physics, general, earthscience - Expand Database type to include all API values (astrophysics, heliophysics, planetary) - Update mock data to reflect real API response with all 7 values
thostetler
force-pushed
the
scix-817-filter-collections-facet
branch
from
fc73f4a to
e87b1d0
Compare
Member
Author
|
@kelockhart please check the photo in the main description, is this the expected behavior? |
Member
Yep! |
shinyichen
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filter out planetary, helio, astrophysics from the collections facet