Fix search results loading layout#779
Merged
thostetler merged 1 commit intoadsabs:masterfrom Jan 26, 2026
Merged
Conversation
thostetler
approved these changes
Jan 23, 2026
Member
thostetler
left a comment
thostetler
left a comment
There was a problem hiding this comment.
Wow quite an improvement with that one minor change. Nice find!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #779 +/- ##
========================================
- Coverage 61.0% 61.0% -0.0%
========================================
Files 301 301
Lines 35173 35173
Branches 1519 1519
========================================
- Hits 21439 21436 -3
- Misses 13700 13703 +3
Partials 34 34 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quick fix of the search results layout shift from loading skeleton to data rendering. Show the facet is loading instead of hiding it.
Screen.Recording.2026-01-23.at.12.09.14.PM.mov