Skip to content

Conversation

@thostetler
Copy link
Member

@thostetler thostetler commented Feb 5, 2026

Adds empty state panels to paper detail sub-pages when no results are
available.

When users navigate directly to pages like /abs/xxx/citations via shared link or bookmark,
they previously saw a blank page. Now they see a card with an explanation and navigation
options.

  • New EmptyStatePanel component
  • Replaced inline Chakra Alerts with StandardAlertMessage for consistency
image

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 92.95775% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.4%. Comparing base (16137e0) to head (860dd86).

Files with missing lines Patch % Lines
src/utils/logging.ts 50.0% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #792     +/-   ##
========================================
+ Coverage    61.3%   61.4%   +0.2%     
========================================
  Files         307     306      -1     
  Lines       35535   35478     -57     
  Branches     1553    1556      +3     
========================================
+ Hits        21761   21766      +5     
+ Misses      13738   13676     -62     
  Partials       36      36             
Files with missing lines Coverage Δ
src/components/Feedbacks/EmptyStatePanel.tsx 100.0% <100.0%> (ø)
src/components/Feedbacks/index.ts 100.0% <100.0%> (ø)
src/utils/logging.ts 70.0% <50.0%> (+6.8%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thostetler thostetler requested a review from shinyichen February 5, 2026 03:52
@thostetler thostetler marked this pull request as ready for review February 5, 2026 03:52
Add informative empty state panels to paper detail sub-pages when no
results are available. Previously users saw a blank page when navigating
directly to pages like /abs/xxx/citations via shared link or bookmark.

- New EmptyStatePanel component in src/components/Feedbacks/
- Applied to citations, references, coreads, similar, toc, credits, mentions
- Card-style display with title, description, and Back to Abstract button
- Simplified page implementations: removed ramda, cleaned up unused code
- Unified error handling with StandardAlertMessage
Copy link
Member

@shinyichen shinyichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thostetler thostetler merged commit 42c4e54 into adsabs:master Feb 10, 2026
5 checks passed
@thostetler thostetler deleted the empty-state-panels branch February 10, 2026 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants