fix(feedback): improve ESOURCE link parsing#806
Merged
thostetler merged 1 commit intoadsabs:masterfrom Feb 18, 2026
Merged
Conversation
- Return empty on non-2xx responses (404 was leaking footer links) - Detect redirects via res.redirected instead of dead res.status === 302 - Use DOMParser to scope parsing to .list-group-item links only - Remove brittle SKIP_URLS blocklist and page-wide href regex
39e8cfe to
0239af2
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #806 +/- ##
========================================
- Coverage 62.0% 61.9% -0.0%
========================================
Files 315 315
Lines 36392 36391 -1
Branches 1631 1632 +1
========================================
- Hits 22537 22526 -11
- Misses 13818 13828 +10
Partials 37 37
🚀 New features to boost your workflow:
|
shinyichen
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feedback page's URL list (via useGetResourceLinks) was scraping
footer links from the link_gateway ESOURCE page on 404 responses, and
the redirect detection was non-functional.
For testing: https://scixplorer.org/abs/1986JAVSO..15..282W/abstract