fix(sentry): correct timing calculations in performance spans#822
Merged
thostetler merged 1 commit intoadsabs:masterfrom Mar 10, 2026
Merged
fix(sentry): correct timing calculations in performance spans#822thostetler merged 1 commit intoadsabs:masterfrom
thostetler merged 1 commit intoadsabs:masterfrom
Conversation
performance.now() returns milliseconds relative to page load, not epoch timestamps. The duration calculation was subtracting epoch ms from relative ms (producing garbage), and span.end() was receiving relative seconds instead of epoch seconds (causing Sentry to drop the spans silently).
2897ac7 to
1eaee69
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes incorrect Sentry performance span timing by aligning relative performance.now() values with epoch-based timestamps, preventing invalid durations and dropped spans.
Changes:
- Update
timing.results.shownmeasurement to useperformance.now()directly (ms since navigation start). - Convert span end time from relative seconds to epoch seconds by offsetting with
performance.timeOrigin/performance.timing.navigationStart.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
performance.now() returns milliseconds relative to page load, not
epoch timestamps. The duration calculation was subtracting epoch ms
from relative ms (producing garbage), and span.end() was receiving
relative seconds instead of epoch seconds (causing Sentry to drop
the spans silently).