Skip to content

Fix incorrect record form single url no loading#837

Merged
shinyichen merged 2 commits intoadsabs:masterfrom
shinyichen:SCIX-627-incorrect-record-form-urls
Apr 15, 2026
Merged

Fix incorrect record form single url no loading#837
shinyichen merged 2 commits intoadsabs:masterfrom
shinyichen:SCIX-627-incorrect-record-form-urls

Conversation

@shinyichen
Copy link
Copy Markdown
Member

@shinyichen shinyichen commented Apr 7, 2026

Update how we get a record's esource (urls) in incorrect record form, so that all urls can be loaded.

Previous we were using link_gateway page and parse urls in the html page. This was a problem when a record has only one url, which was instead redirected to that url instead. We were not able to parse the single url.

The screenshots show that records with single url and multiple urls are loaded.

2013admf.book.....D
Screenshot 2026-04-07 at 12 47 29 PM

2022AAS...24034906L
Screenshot 2026-04-07 at 12 48 00 PM

@shinyichen shinyichen requested a review from thostetler April 7, 2026 19:50
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.4%. Comparing base (006cf95) to head (925d259).

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #837     +/-   ##
========================================
- Coverage    62.5%   62.4%   -0.0%     
========================================
  Files         317     316      -1     
  Lines       36576   36512     -64     
  Branches     1673    1663     -10     
========================================
- Hits        22827   22769     -58     
+ Misses      13709   13703      -6     
  Partials       40      40             
Files with missing lines Coverage Δ
.../components/FeedbackForms/MissingRecord/UrlUtil.ts 100.0% <100.0%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@thostetler thostetler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes look reasonable 👍

@shinyichen shinyichen merged commit 897757a into adsabs:master Apr 15, 2026
5 checks passed
@shinyichen shinyichen deleted the SCIX-627-incorrect-record-form-urls branch April 15, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants