Skip to content

Few small accessibility fixes#842

Merged
shinyichen merged 6 commits intoadsabs:masterfrom
shinyichen:a11y
Apr 15, 2026
Merged

Few small accessibility fixes#842
shinyichen merged 6 commits intoadsabs:masterfrom
shinyichen:a11y

Conversation

@shinyichen
Copy link
Copy Markdown
Member

  • Fix color contrasts
  • Add skip facets link in
  • Add skip abstract navigation link in abstract
  • Add skip author list link in abstract
Screen.Recording.2026-04-09.at.2.45.33.PM.mov

@shinyichen shinyichen requested a review from thostetler April 9, 2026 21:46
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.5%. Comparing base (006cf95) to head (781aad2).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/theme.ts 73.4% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #842     +/-   ##
========================================
- Coverage    62.5%   62.5%   -0.0%     
========================================
  Files         317     317             
  Lines       36576   36591     +15     
  Branches     1673    1673             
========================================
+ Hits        22827   22835      +8     
- Misses      13709   13716      +7     
  Partials       40      40             
Files with missing lines Coverage Δ
src/components/Feedbacks/EmptyStatePanel.tsx 100.0% <100.0%> (ø)
src/theme.ts 91.6% <73.4%> (-0.8%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shinyichen
Copy link
Copy Markdown
Member Author

Convert it to draft, more items to fix.

@shinyichen shinyichen marked this pull request as ready for review April 13, 2026 17:53
Copy link
Copy Markdown
Member

@thostetler thostetler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shinyichen shinyichen merged commit 9e57c4d into adsabs:master Apr 15, 2026
5 checks passed
@shinyichen shinyichen deleted the a11y branch April 15, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants