Skip to content

Conversation

@deiteris
Copy link
Contributor

@deiteris deiteris commented Mar 8, 2021

  1. Use heading variables in the .section.endpoints-title class.
  2. Add the --api-summary-endpoint-path-font-weight variable to control font weight of the .endpoint-path class.
  3. Add --arc-font-subhead-color to allow heading color modification.

jarrodek
jarrodek previously approved these changes Mar 12, 2021
Copy link
Member

@jarrodek jarrodek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but, please, don't merge until @twoplustwoone confirms it is safe to change CSS vars.

@jarrodek jarrodek requested a review from twoplustwoone March 12, 2021 00:31
@deiteris
Copy link
Contributor Author

deiteris commented Mar 14, 2021

LGTM but, please, don't merge until @twoplustwoone confirms it is safe to change CSS vars.

But variables were not changed in this PR. I only added new variables and used existing ones.

twoplustwoone
twoplustwoone previously approved these changes Mar 15, 2021
Copy link
Contributor

@twoplustwoone twoplustwoone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM

@deiteris
Copy link
Contributor Author

deiteris commented Mar 15, 2021

Force-pushed same commits with signature.

@jarrodek jarrodek merged commit 7ea7e1a into advanced-rest-client:stage Mar 18, 2021
jarrodek added a commit that referenced this pull request Mar 18, 2021
* Refactor styles, add variable to adjust heading color (#14)

* refactor: use variables for font-weights

* feat: use existing variables to style endpoints title

* feat: add variable to adjust section heading color

* docs: adjust readme formatting

* ci: updating release pipeline

Signed-off-by: Pawel Psztyc <jarrodek@gmail.com>

* build: bumping version

Signed-off-by: Pawel Psztyc <jarrodek@gmail.com>

Co-authored-by: Ci agent <arc@mulesoft.com>
Co-authored-by: Yury <RIP95_95@mail.ru>
jarrodek added a commit that referenced this pull request Mar 19, 2021
* Refactor styles, add variable to adjust heading color (#14)

* refactor: use variables for font-weights

* feat: use existing variables to style endpoints title

* feat: add variable to adjust section heading color

* docs: adjust readme formatting

* ci: updating release pipeline

Signed-off-by: Pawel Psztyc <jarrodek@gmail.com>

* build: bumping version

Signed-off-by: Pawel Psztyc <jarrodek@gmail.com>

* chore: updating dependencies

Signed-off-by: Pawel Psztyc <jarrodek@gmail.com>

* chore: updating deps and bumping version

Signed-off-by: Pawel Psztyc <jarrodek@gmail.com>

* chore: removing unused demo file

Signed-off-by: Pawel Psztyc <jarrodek@gmail.com>

* docs: updating readme file

Signed-off-by: Pawel Psztyc <jarrodek@gmail.com>

Co-authored-by: Ci agent <arc@mulesoft.com>
Co-authored-by: Yury <RIP95_95@mail.ru>
benri pushed a commit to benri/api-summary that referenced this pull request Mar 22, 2021
…client#14)

* refactor: use variables for font-weights

* feat: use existing variables to style endpoints title

* feat: add variable to adjust section heading color

* docs: adjust readme formatting
twoplustwoone pushed a commit that referenced this pull request Apr 19, 2021
* Refactor styles, add variable to adjust heading color (#14)

* refactor: use variables for font-weights

* feat: use existing variables to style endpoints title

* feat: add variable to adjust section heading color

* docs: adjust readme formatting

* add css parts

* part: separator, toc, api-title-label

* hide toc

* update unit tests

* margin var

* update type def

* update doc

* bump version

Co-authored-by: Yury <RIP95_95@mail.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants