Skip to content

Conversation

@benri
Copy link
Contributor

@benri benri commented Mar 22, 2021

Fixes #27

  • Add CSS parts to major sections
  • Add api to not render the endpoints table of contents
  • customize separator margin

@salesforce-cla
Copy link

Thanks for the contribution! It looks like @benri is an internal user so signing the CLA is not required. However, we need to confirm this.

@benri benri force-pushed the bl/style-extend branch from 44d742e to 3506ded Compare March 22, 2021 22:57
deiteris and others added 4 commits March 22, 2021 16:00
…client#14)

* refactor: use variables for font-weights

* feat: use existing variables to style endpoints title

* feat: add variable to adjust section heading color

* docs: adjust readme formatting
@benri benri force-pushed the bl/style-extend branch from 3506ded to d79ab61 Compare March 22, 2021 23:02
@jarrodek
Copy link
Member

Hey, could you please confirm CLA? @benri

@benri
Copy link
Contributor Author

benri commented Mar 23, 2021

@jarrodek Yes, I followed the CLA link to a form and filled out the information so that they can verify I am an internal member. Thanks!

<div class="api-title" role="heading" aria-level="${titleLevel}">
<label>API title:</label>
<div class="api-title" role="heading" aria-level="${titleLevel}" part="api-title">
<label part="api-title-label">API title:</label>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to include the CSS Parts in the doc so people know what is capable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea, I'll include a doc

@benri benri requested a review from jarrodek March 29, 2021 17:33
@KrisGraySFDC
Copy link

@jarrodek Ben did the signing of the salesforce-cla, but its obviously not picking it up.

Can we re-run the job? Is there someone I need to talk to?

Copy link
Contributor

@twoplustwoone twoplustwoone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you bump the version so I can merge it?

@benri benri force-pushed the bl/style-extend branch from be49082 to 26c0d5e Compare April 14, 2021 23:59
@benri benri force-pushed the bl/style-extend branch from 26c0d5e to 74faf23 Compare April 15, 2021 00:02
@benri benri requested a review from twoplustwoone April 15, 2021 00:03
@KrisGraySFDC
Copy link

@twoplustwoone is it possible to get Benri added to the github organization so his CLA will pass?
Also any way to merge this? We're hoping to get this shipped out later in the week and still need to update NPM with the latest packages, update our versions and re-style them.

@twoplustwoone twoplustwoone merged commit 83db825 into advanced-rest-client:master Apr 19, 2021
@benri benri deleted the bl/style-extend branch April 20, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Component style extend & customization

5 participants