-
Notifications
You must be signed in to change notification settings - Fork 3
API Summary Style Customization #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Summary Style Customization #17
Conversation
|
Thanks for the contribution! It looks like @benri is an internal user so signing the CLA is not required. However, we need to confirm this. |
…client#14) * refactor: use variables for font-weights * feat: use existing variables to style endpoints title * feat: add variable to adjust section heading color * docs: adjust readme formatting
|
Hey, could you please confirm CLA? @benri |
|
@jarrodek Yes, I followed the CLA link to a form and filled out the information so that they can verify I am an internal member. Thanks! |
| <div class="api-title" role="heading" aria-level="${titleLevel}"> | ||
| <label>API title:</label> | ||
| <div class="api-title" role="heading" aria-level="${titleLevel}" part="api-title"> | ||
| <label part="api-title-label">API title:</label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to include the CSS Parts in the doc so people know what is capable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good idea, I'll include a doc
|
@jarrodek Ben did the signing of the salesforce-cla, but its obviously not picking it up. Can we re-run the job? Is there someone I need to talk to? |
twoplustwoone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you bump the version so I can merge it?
|
@twoplustwoone is it possible to get Benri added to the github organization so his CLA will pass? |
Fixes #27