Add UI5 fragment support to cds extractor #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
data-douser
approved these changes
Dec 11, 2025
Collaborator
data-douser
left a comment
data-douser
left a comment
There was a problem hiding this comment.
We will need an equivalent change for extractors/javascript/tools/pre-finalize.cmd, but that does not need to be added in this PR as pre-finalize.cmd is already out-of-sync with pre-finalize.sh. The required fixes for pre-finalize.cmd are tracked via #271 .
Approving this PR as is, with an eye on in-progress checks.
knewbury01
deleted the
knewbury01/add-fragement-extraction-cds-extractor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What This PR Contributes
similar to this PR, the cds extractor needs to know about extra xml files to index. We may support fragments in the near future, and then it would be required for the cds extractor to be able to extract those
Future Works
fragment modelling, as in a separate PR