-
Notifications
You must be signed in to change notification settings - Fork 2
Better logging and documentation support #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks good to me. I left a few comments. Another note (which doesn't necessarily relate to this PR): Supplying multiple languages via Do we really want to allow supplying multiple languages? I'd say most callers know for which languages they want the customizations, which would make the implementation much easier for us. Also, I retract my suggestion of making |
zbazztian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.