Merged
Conversation
- Added check to prevent fainted or inactive Pokemon from using their move - Changed how the branch probability limit worked so events that would cause one branch to be above the limit and the other below no longer split - Moved the vertical slice tests to their own file - Simplified how the ideal number of outcomes is calculated - Fixed incorrect calculations for whether an outcome would be included in a given test configuration - It only worked before because the old wrong number and what's correct coincidentally led the variables to be same value
- Implemented residual damage from burn - Fixed how boost values are clamped - Set the RanAfterModifyDamage tag to be removed after onDamage is done
The numerator was the wrong value and its uses were not correct - Changed functions that returned a probability type to return a number from 1 to 0 instead of 1 to 100 - Updated updateProbability to work on probabilities and percentChance without changing either number
- Added entity specific tests to ensure the values of the Pokemon and battles are correct - Updated some of the shared functions and variables between the single and double battle tests to be easier to use between both Writing code to find the ideal probability for this double battle scenario was difficult. I considered changing the scenario so there wouldn't be a cause where it's impossible to find one probability that's correct given the end-of-turn state, but the solution around that (making sure the probabilities of all outcomes adds up to the original probability and making sure both probability values are found within all the outcomes) works.
Closed
16 tasks
Contributor
|
🤖 Passed All One Review Bot Checks ✔️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only took me three years...