Skip to content

Conversation

@Kuboczoch
Copy link
Contributor

Description

Fix relativePath variable in storybook depending on the platform.
For my case using windows, I now can run yarn storybook without any issue

Fixes #40

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I executed yarn storybook command from package.json

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@Kuboczoch Kuboczoch changed the title Fix storybook relativePath depending on used platform #40 Fix storybook relativePath depending on used platform Jan 9, 2022
Copy link
Owner

@aeksco aeksco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kuboczoch Very nice catch, thank you so much! Really appreciate the contribution 🥇

@aeksco aeksco merged commit c368682 into aeksco:main Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error while starting a storybook from default configuration

2 participants