BZ 783128 - Renames "Image URI" to "Provider's Image ID"#36
Closed
n1zyy wants to merge 15 commits intoaeolusproject:masterfrom
Closed
BZ 783128 - Renames "Image URI" to "Provider's Image ID"#36n1zyy wants to merge 15 commits intoaeolusproject:masterfrom
n1zyy wants to merge 15 commits intoaeolusproject:masterfrom
Conversation
Member
|
ACK, just a note: I think the key for the translation should be |
…only when relevant To add html tags to i18n message variables, the yaml key has to end with "_html" http://stackoverflow.com/questions/5367705/rails-3-i18n-interpolating-html-tags-into-text
…ebased) A reason why deletion failed is now displayed. This required more changes (cleanups): - fixes formatting of flash error - moves destroy_deployment_config call into before_destroy callback - fixes setting of flash message on multi_destroy action - adds new exception to catch (most common) stop&destroy error - unstoppable instance
Stub out calls to Image Warehouse to ensure that queries for images present in a pool family do not fail. Completes RM3727, RM3729, RM3730, RM3731, RM3732. Signed-off-by: Jason Guiditta <jguiditt@redhat.com>
Stub out an image status call to avoid interaction with external services. Completes RM3450. Signed-off-by: Jason Guiditta <jguiditt@redhat.com>
The content should be conditional on permissions, but omitting the container itself causes styling problems.
Adds tests too.
Also fixes assemblies method - if root node doesn't exist, empty array is returned - w/o this an exception was raised in validation process when checking cyclic references.
If partial launch is enabled and all instances fails, the deployment is marked as failed instead of running. Also if there is a failed instance but rest of instances are running, the deployment is marked as incomplete.
Neither of the tabs are highlighted on the path like /pools?view=filter
Beyond the fact that it's not actually a URI at all, it's unclear what it is. We decided "Provider's Image ID" was clearer. https://bugzilla.redhat.com/show_bug.cgi?id=783128
Member
Author
|
Well that didn't go well. I'm going to close this and open a new one rather than try to do something fancy with force-pushing like I just did... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beyond the fact that it's not actually a URI at all, it's unclear
what it is. We decided "Provider's Image ID" was clearer.
https://bugzilla.redhat.com/show_bug.cgi?id=783128