Skip to content

Comments

the penultimate exception is thrown instead of the last one#63

Merged
norberttech merged 3 commits intoaeon-php:1.xfrom
maciejlebkowski:fix/last-exception-is-lost
Sep 15, 2023
Merged

the penultimate exception is thrown instead of the last one#63
norberttech merged 3 commits intoaeon-php:1.xfrom
maciejlebkowski:fix/last-exception-is-lost

Conversation

@maciejlebkowski
Copy link
Contributor

@maciejlebkowski maciejlebkowski commented Sep 15, 2023

Description

When a series of different exceptions is thrown, the last one is expected to be thrown from the Retry::execute() call

Actually, the second-to-last one is thrown.

Change Log

Added

Fixed

  • The correct exception is thrown if multiple ones occur during execution

Changed

Updated

Removed

Deprecated

Security


@norberttech norberttech enabled auto-merge (squash) September 15, 2023 18:04
@norberttech norberttech merged commit 9100386 into aeon-php:1.x Sep 15, 2023
@mlebkowski
Copy link
Contributor

thx ;) if you could please tag 1.0.9 before Monday — I have a PR that would benefit from this change 😂

@norberttech
Copy link
Member

thanks @maciejlebkowski I will tag new version tomorrow 😁

@norberttech
Copy link
Member

@mlebkowski i just released 1.0.9, sorry for the delay

@maciejlebkowski maciejlebkowski deleted the fix/last-exception-is-lost branch September 18, 2023 07:39
@maciejlebkowski
Copy link
Contributor Author

thx, appreciate quick reaction 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants