Adop AEP 127: HTTP and gRPC Transcoding#159
Merged
rambleraptor merged 4 commits intoaep-dev:mainfrom Apr 12, 2024
Merged
Conversation
rofrankel
requested changes
Apr 5, 2024
Collaborator
rofrankel
left a comment
rofrankel
left a comment
There was a problem hiding this comment.
Ideally this would follow the "cheat sheet" pattern:
- First commit just copy/pastes the content, unmodified.
- Next commit de-Googles the content.
- Next commit adds proto/OAS tabs (inapplicable in this PR).
- Any other content changes are in subsequent commits.
Member
Author
|
I made this PR line up with the cheat sheet approach and addressed your comments, ptal! |
rofrankel
approved these changes
Apr 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Proposed changes
Adopt AEP 127 for #51
🍱 Types of changes
What types of changes does your code introduce to AEP? Put an
xin the boxesthat apply
📋 Your checklist for this pull request
Please review the AEP Style and Guidance for
contributing to this repository.
General
references AEPs
correctly.
Additional checklist for a new AEP
guidelines are met.
Document structure
guidelines are met.
💝 Thank you!