Skip to content

chore: add prettier to checklist #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
toumorokoshi merged 2 commits into from
Apr 12, 2024
Merged

chore: add prettier to checklist #167

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
912a825
chore: add prettier to checklist
toumorokoshi Apr 11, 2024
e964f78
adding a few more niceties
toumorokoshi Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
## 📑 Proposed changes

<!--
Describe the big picture of your changes here to communicate to the maintainers
why we should accept this pull request. If it fixes a bug or resolves a feature
request, be sure to link to that issue.
-->

## 🍱 Types of changes

Expand All @@ -12,6 +12,7 @@ that apply_
- [ ] Enhancement
- [ ] [New proposal](https://aep.dev/1#workflow)
- [ ] Migrated from google.aip.dev
- [ ] Chore / Quick Fix

## 📋 Your checklist for this pull request

Expand All @@ -24,9 +25,13 @@ contributing to this repository.
- [ ] Ensure that your PR
[references AEPs](https://aep.dev/style-guide#referencing-aeps)
correctly.
- [ ] [My code has been formatted](https://aep.dev/contributing#formatting)
(usually `prettier -w .`)

### Additional checklist for a new AEP

<!-- delete if this is not a new AEP -->

- [ ] A new AEP **should** be no more than two pages if printed out.
- [ ] Ensure that the PR is editable by maintainers.
- [ ] Ensure that [File structure](https://aep.dev/style-guide#file-structure)
Expand Down