Skip to content

chore(serve.sh): add port feature#198

Merged
toumorokoshi merged 1 commit intoaep-dev:mainfrom
toumorokoshi:yft/customize-port
Jul 5, 2024
Merged

chore(serve.sh): add port feature#198
toumorokoshi merged 1 commit intoaep-dev:mainfrom
toumorokoshi:yft/customize-port

Conversation

@toumorokoshi
Copy link
Copy Markdown
Member

Sometimes there is a different service running at port 4000 locally, so it's not possible to use serve.sh.

Add a port field to allow it's customization.

🍱 Types of changes

What types of changes does your code introduce to AEP? Put an x in the boxes
that apply

  • Enhancement
  • New proposal
  • Migrated from google.aip.dev
  • Chore / Quick Fix

📋 Your checklist for this pull request

Please review the AEP Style and Guidance for
contributing to this repository.

General

💝 Thank you!

Sometimes there is a different service running at port 4000
locally, so it's not possible to use serve.sh.

Add a port field to allow it's customization.
@toumorokoshi toumorokoshi requested a review from a team as a code owner July 5, 2024 23:56
@toumorokoshi toumorokoshi merged commit 22ee46d into aep-dev:main Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants