fix(standard-methods): clarify optional parent fields #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is currently some inconsistency with the description of parent fields on standard methods, and whether they are required. Clarifying that they are indeed optional, as the resource may not have a parent.
rambleraptor
approved these changes
Dec 13, 2024
rofrankel
approved these changes
Dec 13, 2024
Collaborator
rofrankel
left a comment
rofrankel
left a comment
There was a problem hiding this comment.
Approved modulo comments, and feel free to just fix the "and and" typo and merge if the other one isn't also some kind of typo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently some inconsistency with the description of parent fields on standard methods, and whether they are required.
Clarifying that they are indeed optional, as the resource may not have a parent.
🍱 Types of changes
What types of changes does your code introduce to AEP? Put an
xin the boxesthat apply
📋 Your checklist for this pull request
Please review the AEP Style and Guidance for
contributing to this repository.
General
references AEPs
correctly.
(usually
prettier -w .)💝 Thank you!