AER-2978 Validation on building radius#283
Merged
BertScholten merged 3 commits intoaerius:mainfrom Jun 10, 2024
Merged
Conversation
This change also means validation on import gets a bit stricter, and OPS characteristics based applications won't allow circular buildings anymore (which they shouldn't anyway).
BertScholten
force-pushed
the
AER-2978_building_radius_validation
branch
from
85c3e84 to
063363d
Compare
Hilbrand
reviewed
Jun 10, 2024
source/imaer-util/src/main/java/nl/overheid/aerius/validation/BuildingValidator.java
Outdated
Show resolved
Hide resolved
source/imaer-util/src/main/java/nl/overheid/aerius/validation/BuildingValidator.java
Show resolved
Hide resolved
- Just validate as much as possible, so user doesn't have to upload multiple times - Added a comment about why the warning check is in the location it is in.
Hilbrand
reviewed
Jun 10, 2024
source/imaer-util/src/main/java/nl/overheid/aerius/validation/BuildingValidator.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change also means validation on import gets a bit stricter, and OPS characteristics based applications won't allow circular buildings anymore (which they shouldn't anyway).