AER-2804 serialize ScenarionSituationResults to be ably to pass calculation id via message bus#302
Merged
Hilbrand merged 1 commit intoaerius:mainfrom Sep 24, 2024
Conversation
…lation id via message bus Than the calculation id can be used to retrieve the results to put in the GML. But we don't want to serializer results in this class as those are not needed, but only add to the message load.
BertScholten
approved these changes
Sep 23, 2024
Member
BertScholten
left a comment
BertScholten
left a comment
There was a problem hiding this comment.
LGTM (I think, not too sure how it ends up being used)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Than the calculation id can be used to retrieve the results to put in the GML. But we don't want to serialize results in this class as those are not needed, but only add to the message load.