Refactor ReceptorGridSettings into an enum#330
Merged
Hilbrand merged 2 commits intoaerius:mainfrom Apr 22, 2025
Merged
Conversation
Since the values of ReceptorGridSettings don't change they can be hard-coded. Fixed unit tests, due to wrong coordinates in example ReceptorGridSettings (another reason to use a enum with the values in one place).
SerhatG
reviewed
Apr 18, 2025
...ce/imaer-shared/src/main/java/nl/overheid/aerius/shared/domain/geo/ReceptorGridSettings.java
Outdated
Show resolved
Hide resolved
…main/geo/ReceptorGridSettings.java Co-authored-by: Serhat <SerhatG@users.noreply.github.com>
JornC
added a commit
to JornC/IMAER-java
that referenced
this pull request
Apr 24, 2025
This reverts commit 6a15b13.
JornC
added a commit
to JornC/IMAER-java
that referenced
this pull request
Apr 24, 2025
This reverts commit 09404a9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the values of ReceptorGridSettings don't change they can be hard-coded. Breaking change: Changes
RecetorSettingsGridfrom a class into a enum.