AER-4143 Vehicle-based characteristics removed vehicle conversion#371
Merged
BertScholten merged 4 commits intoaerius:mainfrom Feb 24, 2026
Merged
Conversation
Properly handle vehicle-based characteristics cold start conversion of specific vehicles to custom vehicles. Bit annoying having to hardcode the vehicle type, but rather not make the whole functionality more specific by having that configurable as well (would mean a specific table, while for now we went with a generic approach...).
The vehicle based characteristics is cold start specific, so better to keep it there rather than putting it in the util which is shared between the two types.
BertScholten
force-pushed
the
AER-4143_cold_start_conversion_vehicle_based
branch
from
0a8930e to
3151603
Compare
Hilbrand
approved these changes
Feb 24, 2026
Member
Hilbrand
left a comment
Hilbrand
left a comment
There was a problem hiding this comment.
LGTM. Just a comment related to
source/imaer-gml/src/main/java/nl/overheid/aerius/gml/base/source/road/GML2ColdStart.java
Show resolved
Hide resolved
BertScholten
deleted the
AER-4143_cold_start_conversion_vehicle_based
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly handle vehicle-based characteristics cold start conversion of specific vehicles to custom vehicles. Bit annoying having to hardcode the vehicle type, but rather not make the whole functionality more specific by having that configurable as well (would mean a specific table, while for now we went with a generic approach...).