add log table for loggin import-table logdata.#52
Merged
Conversation
JacobusXIII
requested changes
Dec 3, 2025
Contributor
JacobusXIII
left a comment
JacobusXIII
left a comment
There was a problem hiding this comment.
Great first version! Now it needs some polishing up ;)
JacobusXIII
requested changes
Dec 3, 2025
JacobusXIII
requested changes
Dec 3, 2025
Contributor
There was a problem hiding this comment.
Should we be more specific about naming? Like table_data_metadata instead of just metadata or so?
@BertScholten what do you think?
JacobusXIII
requested changes
Dec 4, 2025
Contributor
Author
|
Contributor
Author
|
decided: metadata table will be renamed to "load_table_logs" |
JacobusXIII
requested changes
Dec 5, 2025
Contributor
JacobusXIII
left a comment
JacobusXIII
left a comment
There was a problem hiding this comment.
The action being performed is registering all load_tables, which result in een entry in the load_table_logs table. That's why I'm in favor of the name register_load_table as a function-, boolean- and contants-name.
JacobusXIII
requested changes
Dec 14, 2025
eltee1
changed the title
Member
BertScholten
left a comment
BertScholten
left a comment
There was a problem hiding this comment.
Bit late to the party perhaps (went over open PRs to check if anything could be closed), but had a suggestion.
eltee1
changed the title
…he default value of the should_register_load_table to TRUE. With this change, de build default is to register the metadata in the table log data.
JacobusXIII
requested changes
Jan 14, 2026
…=false: register.
JacobusXIII
changed the title
JacobusXIII
changed the title
JacobusXIII
requested changes
Jan 14, 2026
JacobusXIII
requested changes
Jan 15, 2026
Contributor
JacobusXIII
left a comment
JacobusXIII
left a comment
There was a problem hiding this comment.
Last issue hopefully
JacobusXIII
approved these changes
Jan 20, 2026
eltee1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a log table for logging import-table logdata and functionalily to fill it.
This table is filled during the database-build with some metadata from the imported import-files, like the name of the file, the import-time and the checksums of the table before and after the import. This is done by a altered function of "load_table".
This overwiew can be used for checks on the database build(are the correct import-files used during the build-proces?).
Also, often is the question what import-file is used for a particular table. This information is placed in the .html- and .rtf files, but these stand apart from the database, so if those can't be found, there is no way to know.
With the introduction of this log-table, the used import-files can be easy to find.