Conversation
Comment on lines
+42
to
+43
| <sonar.organization>aerius</sonar.organization> | ||
| <sonar.host.url>https://sonarcloud.io</sonar.host.url> |
Member
There was a problem hiding this comment.
Perhaps we could move these to the root pom?
source/pom.xml
Outdated
Comment on lines
109
to
116
| <executions> | ||
| <execution> | ||
| <id>prepare-agent</id> | ||
| <goals> | ||
| <goal>prepare-agent</goal> | ||
| </goals> | ||
| </execution> | ||
| </executions> |
Member
There was a problem hiding this comment.
Think this is specified in the root pom in pluginManagement and as such doesn't need to be included? Could be wrong though, didn't test it.
Member
Author
There was a problem hiding this comment.
@Hilbrand did it for Register as well, so I thought if the master did.. but you are right I think.. Let me revert it and test it out.
SerhatG
force-pushed
the
add_sonar_settings
branch
from
9cb4dac to
7f6ad1d
Compare
BertScholten
approved these changes
May 10, 2023
Member
BertScholten
left a comment
BertScholten
left a comment
There was a problem hiding this comment.
LGTM, can move the properties later if you want to get the build going ;)
| <sonar.moduleKey>${project.artifactId}</sonar.moduleKey> | ||
| <sonar.organization>aerius</sonar.organization> | ||
| <sonar.host.url>https://sonarcloud.io</sonar.host.url> | ||
| <sonar.java.pmd.reportPaths>${project.build.directory}/dependency-check-report-pmd.xml</sonar.java.pmd.reportPaths> |
Member
There was a problem hiding this comment.
Not generating any pmd reports atm, so a bit pointless.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.