Skip to content
This repository was archived by the owner on Apr 17, 2023. It is now read-only.

Change SchemaMigration ID type to number#503

Merged
craicoverflow merged 6 commits into
masterfrom
chore/change-id-type
Nov 22, 2019
Merged

Change SchemaMigration ID type to number#503
craicoverflow merged 6 commits into
masterfrom
chore/change-id-type

Conversation

@craicoverflow

@craicoverflow craicoverflow commented Nov 22, 2019

Copy link
Copy Markdown

Motivation

Fixes #495

What

Change the ID type of SchemaMigration to match the ID type in the database.

Verification

Postgres

Postgres migrations should work as before.

SQLite

  1. Install sqlite3 to the runtime example.
  2. Change database configuration to:
"db": {
  "database": "sqlite3",
  "dbConfig": {
    "filename": "./db.sqlite"
  }
},
  1. Executing migrations with SQLite should now work.

@craicoverflow craicoverflow marked this pull request as ready for review November 22, 2019 12:09
@wtrocki

wtrocki commented Nov 22, 2019

Copy link
Copy Markdown
Contributor

WDYT about moving runtime to sqllite?

@craicoverflow craicoverflow merged commit 06dffe4 into master Nov 22, 2019
@wtrocki wtrocki deleted the chore/change-id-type branch November 22, 2019 13:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Database migration doesn't work with sqlite

2 participants