This repository was archived by the owner on Apr 17, 2023. It is now read-only.
Readme and delete bug#48
Merged
Merged
Conversation
wtrocki
reviewed
Jun 12, 2019
wtrocki
reviewed
Jun 12, 2019
| import { expect, should } from "chai"; | ||
| import { CREATE_ITEM, GET_ITEMS } from "./mock/mutations"; | ||
|
|
||
| describe("Optimistic Response tests", () => { |
Member
Author
There was a problem hiding this comment.
because these tests are in the cache package now, not the client - I just forgot to move this file last time.
wtrocki
approved these changes
Jun 12, 2019
Co-Authored-By: Wojtek Trocki <wtrocki@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We need a readme for this project so I have added that.
Also there was a bug where a delete did not remove from the cache. If a server only returns the id of the object being deleted then we need to cater for that.
Interface improvements to decouple optimistic response from mutation helpers.
Checklist
npm testpassesnpm run buildworks