Skip to content

Conversation

@AindriuBrennan
Copy link
Contributor

This update brings the CLI version inline with the Admin Client. It required extensive refactor of the App and Variant commands and also the Tests and Mocks.
While the client does not fully match the Admin Client in functionality it is at a good base now to add in any further missing features

@coveralls
Copy link

coveralls commented Dec 14, 2020

Pull Request Test Coverage Report for Build 420655336

  • 23 of 24 (95.83%) changed or added relevant lines in 11 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+4.1%) to 80.586%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/utils/UPSAdminClientFactory.ts 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
src/cmds/variants-cmds/handlers/WebPushVariantHandler.ts 7 40.0%
Totals Coverage Status
Change from base Build 145980463: 4.1%
Covered Lines: 165
Relevant Lines: 191

💛 - Coveralls

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ziccardi
Copy link
Member

superseded by #61

@ziccardi ziccardi closed this Dec 16, 2020
@coveralls
Copy link

coveralls commented Dec 2, 2024

Pull Request Test Coverage Report for Build 420611861

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 23 of 24 (95.83%) changed or added relevant lines in 11 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+4.1%) to 80.586%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/utils/UPSAdminClientFactory.ts 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
src/cmds/variants-cmds/handlers/WebPushVariantHandler.ts 7 40.0%
Totals Coverage Status
Change from base Build 145980463: 4.1%
Covered Lines: 165
Relevant Lines: 191

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants