Skip to content

C++ Generator: MessageHeader copy-constructor broken #513

@ksergey

Description

@ksergey

Hi,

Latest stable release generate incorrect copy-constructor for MessageHeader:

    MessageHeader(const MessageHeader& codec) :                                                                                                    
        m_buffer(codec.m_buffer), m_offset(codec.m_offset), m_actingVersion(codec.m_actingVersion){} 

Missed m_bufferLength copying

I believe copy-constructor and copy-operator could be default

#if __cplusplus >= 201103L
MessageHeader(const MessageHeader&) = default;
MessageHeader& operator=(const MessageHeader&) = default;
#endif

Also why you support old c++ standard? I believe will be reasonable to require c++11 for generated code.

Thanks

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions