Skip to content

[C++]: Simplify bool method returns #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2016
Merged

[C++]: Simplify bool method returns #390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/cpp/CppGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,7 @@ private void generateVarDataDescriptors(
indent + " }\n\n" +
indent + " bool %1$sInActingVersion(void)\n" +
indent + " {\n" +
indent + " return (m_actingVersion >= %1$sSinceVersion()) ? true : false;\n" +
indent + " return m_actingVersion >= %1$sSinceVersion();\n" +
indent + " }\n\n" +
indent + " static SBE_CONSTEXPR const std::uint16_t %1$sId(void)\n" +
indent + " {\n" +
Expand Down Expand Up @@ -661,7 +661,7 @@ private CharSequence generateChoices(final String bitsetClassName, final List<To
" bool %1$s(void) const\n" +
" {\n" +
"%2$s" +
" return (%3$s(*((%4$s *)(m_buffer + m_offset))) & (0x1L << %5$s)) ? true : false;\n" +
" return %3$s(*((%4$s *)(m_buffer + m_offset))) & (0x1L << %5$s);\n" +
" }\n\n",
choiceName,
generateChoiceNotPresentCondition(token.version(), BASE_INDENT),
Expand Down Expand Up @@ -1490,7 +1490,7 @@ private CharSequence generateFields(final String containingClassName, final List
indent + " }\n\n" +
indent + " bool %1$sInActingVersion(void)\n" +
indent + " {\n" +
indent + " return (m_actingVersion >= %1$sSinceVersion()) ? true : false;\n" +
indent + " return m_actingVersion >= %1$sSinceVersion();\n" +
indent + " }\n\n",
propertyName,
(long)signalToken.version()
Expand Down