Code refactorings#28
Closed
kashyapm94 wants to merge 5 commits intoaeron7:masterfrom
kashyapm94:code-refactoring
Closed
Code refactorings#28kashyapm94 wants to merge 5 commits intoaeron7:masterfrom kashyapm94:code-refactoring
kashyapm94 wants to merge 5 commits intoaeron7:masterfrom
kashyapm94:code-refactoring
Conversation
- move the current code to the original_rahu.py - add the refactored code to the rahu.py - move the urls & constants to separate modules - bump up the version in setup.py
Owner
|
Do not want to merge. Many functions are community made. Don't want to tamper them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following changes have been made in the branch:
What has not been done here: