CLIENT-4526 Fix error listener's silent omitting#67
Merged
Conversation
tim-aero
reviewed
Mar 26, 2026
Comment on lines
+67
to
+69
| if (errorListener.hasErrors()) { | ||
| throw new DslParseException("Could not parse given DSL expression input"); | ||
| } |
There was a problem hiding this comment.
This would seem to lose any useful information about what the errors are, which is critical. Does the DSLParserErrorListener get information from the parse about what the error is?
Collaborator
Author
There was a problem hiding this comment.
Yes, DSLParserErrorListener does receive detailed error information from ANTLR. The listener only used it for the special float-literal paths, where it threw immediately with a specific message, while error message was printed to stderr. It makes sense now to propagate error message from ANTLR, will push a change soon.
Collaborator
Author
|
Now a combined error message from lexer and parser is propagated via an exception rather than to stderr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.