Skip to content

Fix CreateRenderModel params#1827

Merged
Haselnussbomber merged 1 commit into
aers:mainfrom
Haselnussbomber:fix-CreateRenderModel
May 12, 2026
Merged

Fix CreateRenderModel params#1827
Haselnussbomber merged 1 commit into
aers:mainfrom
Haselnussbomber:fix-CreateRenderModel

Conversation

@Haselnussbomber
Copy link
Copy Markdown
Collaborator

1 parameter too much.

@github-actions
Copy link
Copy Markdown
Contributor

Details

Breaking Changes

Member exists in left but not in right

FFXIVClientStructs.FFXIV.Client.Graphics.Scene.CharacterBase.Delegates: 1

CreateRenderModel: 2

  • FFXIVClientStructs.FFXIV.Client.Graphics.Render.Model* Invoke(FFXIVClientStructs.FFXIV.Client.Graphics.Scene.CharacterBase*, uint, FFXIVClientStructs.FFXIV.Client.System.Resource.Handle.ModelResourceHandle*, System.IntPtr)
  • System.IAsyncResult BeginInvoke(FFXIVClientStructs.FFXIV.Client.Graphics.Scene.CharacterBase*, uint, FFXIVClientStructs.FFXIV.Client.System.Resource.Handle.ModelResourceHandle*, System.IntPtr, System.AsyncCallback, object)

FFXIVClientStructs.FFXIV.Client.Graphics.Scene: 5

CharacterBase: 1

  • FFXIVClientStructs.FFXIV.Client.Graphics.Render.Model* CreateRenderModel(uint, FFXIVClientStructs.FFXIV.Client.System.Resource.Handle.ModelResourceHandle*, System.IntPtr)

Demihuman: 1

  • FFXIVClientStructs.FFXIV.Client.Graphics.Render.Model* CreateRenderModel(uint, FFXIVClientStructs.FFXIV.Client.System.Resource.Handle.ModelResourceHandle*, System.IntPtr)

Human: 1

  • FFXIVClientStructs.FFXIV.Client.Graphics.Render.Model* CreateRenderModel(uint, FFXIVClientStructs.FFXIV.Client.System.Resource.Handle.ModelResourceHandle*, System.IntPtr)

Monster: 1

  • FFXIVClientStructs.FFXIV.Client.Graphics.Render.Model* CreateRenderModel(uint, FFXIVClientStructs.FFXIV.Client.System.Resource.Handle.ModelResourceHandle*, System.IntPtr)

Weapon: 1

  • FFXIVClientStructs.FFXIV.Client.Graphics.Render.Model* CreateRenderModel(uint, FFXIVClientStructs.FFXIV.Client.System.Resource.Handle.ModelResourceHandle*, System.IntPtr)

FFXIVClientStructs.FFXIV.Client.Graphics.Scene.Demihuman.Delegates: 1

CreateRenderModel: 2

  • FFXIVClientStructs.FFXIV.Client.Graphics.Render.Model* Invoke(FFXIVClientStructs.FFXIV.Client.Graphics.Scene.Demihuman*, uint, FFXIVClientStructs.FFXIV.Client.System.Resource.Handle.ModelResourceHandle*, System.IntPtr)
  • System.IAsyncResult BeginInvoke(FFXIVClientStructs.FFXIV.Client.Graphics.Scene.Demihuman*, uint, FFXIVClientStructs.FFXIV.Client.System.Resource.Handle.ModelResourceHandle*, System.IntPtr, System.AsyncCallback, object)

FFXIVClientStructs.FFXIV.Client.Graphics.Scene.Human.Delegates: 1

CreateRenderModel: 2

  • FFXIVClientStructs.FFXIV.Client.Graphics.Render.Model* Invoke(FFXIVClientStructs.FFXIV.Client.Graphics.Scene.Human*, uint, FFXIVClientStructs.FFXIV.Client.System.Resource.Handle.ModelResourceHandle*, System.IntPtr)
  • System.IAsyncResult BeginInvoke(FFXIVClientStructs.FFXIV.Client.Graphics.Scene.Human*, uint, FFXIVClientStructs.FFXIV.Client.System.Resource.Handle.ModelResourceHandle*, System.IntPtr, System.AsyncCallback, object)

FFXIVClientStructs.FFXIV.Client.Graphics.Scene.Monster.Delegates: 1

CreateRenderModel: 2

  • FFXIVClientStructs.FFXIV.Client.Graphics.Render.Model* Invoke(FFXIVClientStructs.FFXIV.Client.Graphics.Scene.Monster*, uint, FFXIVClientStructs.FFXIV.Client.System.Resource.Handle.ModelResourceHandle*, System.IntPtr)
  • System.IAsyncResult BeginInvoke(FFXIVClientStructs.FFXIV.Client.Graphics.Scene.Monster*, uint, FFXIVClientStructs.FFXIV.Client.System.Resource.Handle.ModelResourceHandle*, System.IntPtr, System.AsyncCallback, object)

FFXIVClientStructs.FFXIV.Client.Graphics.Scene.Weapon.Delegates: 1

CreateRenderModel: 2

  • FFXIVClientStructs.FFXIV.Client.Graphics.Render.Model* Invoke(FFXIVClientStructs.FFXIV.Client.Graphics.Scene.Weapon*, uint, FFXIVClientStructs.FFXIV.Client.System.Resource.Handle.ModelResourceHandle*, System.IntPtr)
  • System.IAsyncResult BeginInvoke(FFXIVClientStructs.FFXIV.Client.Graphics.Scene.Weapon*, uint, FFXIVClientStructs.FFXIV.Client.System.Resource.Handle.ModelResourceHandle*, System.IntPtr, System.AsyncCallback, object)

@github-actions github-actions Bot added the breaking change PR contains breaking changes and wont be merged before a new patch label May 12, 2026
@Haselnussbomber
Copy link
Copy Markdown
Collaborator Author

Merging it, since it doesn't work like that and only existed for 10 days.

@Haselnussbomber Haselnussbomber merged commit 7fe9261 into aers:main May 12, 2026
3 of 4 checks passed
@Haselnussbomber Haselnussbomber deleted the fix-CreateRenderModel branch May 12, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change PR contains breaking changes and wont be merged before a new patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant