Skip to content
This repository was archived by the owner on Aug 12, 2024. It is now read-only.

Conversation

@noandrea
Copy link
Contributor

@noandrea noandrea commented Mar 5, 2019

No description provided.

* Move version check to the openapi module against the swagger info version field
* Default tx ttl version to 0
* Increase the available amount of tokens in the genesis account
* Update image for faucet app
* Change reference from Epoch to Aeternity Node
* Set minimum required python version to 3.6
* Fix cli test, set the nonce for offline mode
* Set operations default to native, change parameter name to --debug-tx to use debug tx generation
* Remove legacy aevm submodule
* Move constant identifiers to identifier submodule and use the constants around the codebase
* Better default values for tx ttl, contract deposit and amount, oracle query fee
* Use namedtuple to parse node responses instead of mix namedtuple and dict
* Add generic signature verification
* Update compatibility with node v2.0.0 (minerva)
* New logic for transaction packing/unpacking
* Refactor config to be part of the node submodule
* Api version check moved to the openapi client
* Add wait_for_confirmation method to the node client
* Add new example for spend transaction
Copy link
Contributor

@ricricucit ricricucit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

Copy link
Contributor

@ricricucit ricricucit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small change needed (a comment). Not crucial...so: approved! ✅

# RLP Identifiers

# RLP version number
# https://github.com/aeternity/protocol/blob/api-v0.10.1/serializations.md#binary-serialization
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...or remove it since it's mentioned again in line 77

@noandrea noandrea merged commit 1dca16f into master Mar 5, 2019
@noandrea noandrea removed the review label Mar 5, 2019
@noandrea noandrea deleted the release/v2.0.0 branch May 9, 2019 14:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants