This repository was archived by the owner on Aug 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
Release/v2.0.0 #118
Merged
Merged
Release/v2.0.0 #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move version check to the openapi module against the swagger info version field * Default tx ttl version to 0 * Increase the available amount of tokens in the genesis account
* Update image for faucet app
* Change reference from Epoch to Aeternity Node
* Set minimum required python version to 3.6 * Fix cli test, set the nonce for offline mode * Set operations default to native, change parameter name to --debug-tx to use debug tx generation * Remove legacy aevm submodule * Move constant identifiers to identifier submodule and use the constants around the codebase * Better default values for tx ttl, contract deposit and amount, oracle query fee * Use namedtuple to parse node responses instead of mix namedtuple and dict
* Add generic signature verification
* Update compatibility with node v2.0.0 (minerva)
* New logic for transaction packing/unpacking * Refactor config to be part of the node submodule * Api version check moved to the openapi client * Add wait_for_confirmation method to the node client * Add new example for spend transaction
ricricucit
suggested changes
Mar 5, 2019
Contributor
ricricucit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔
ricricucit
approved these changes
Mar 5, 2019
Contributor
ricricucit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 small change needed (a comment). Not crucial...so: approved! ✅
| # RLP Identifiers | ||
|
|
||
| # RLP version number | ||
| # https://github.com/aeternity/protocol/blob/api-v0.10.1/serializations.md#binary-serialization |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...or remove it since it's mentioned again in line 77
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.