Skip to content

[Bug]: Fixes.fixTypeEverywhere() silently returns input unchanged #117

@Splatcrafter

Description

@Splatcrafter

AI REVIEWED

Module: api
File: api/fix/Fixes.java (~line 165-193)
Severity: Critical

Summary

Fixes.fixTypeEverywhere() does not apply any transformation — it returns the input unchanged. A comment in the code confirms this: "We need to get DynamicOps from somewhere".

Expected Behavior

The method should apply the provided transformation function to all matching types, producing migrated output data.

Actual Behavior

The method silently returns the input without modification. Users believe their data was migrated when it was not — a silent data loss scenario.

Suggested Fix

Either:

  1. Add a DynamicOps parameter and implement the transformation properly, or
  2. Remove the method entirely and document its absence, preventing users from relying on a no-op

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions