Skip to content

Fix stale @return Javadoc on Typed.getAt to reflect error-based behavior#224

Merged
Splatcrafter merged 2 commits intobugfix/117-118-119-120-121-122-123-api-bugfixesfrom
copilot/sub-pr-223
Mar 21, 2026
Merged

Fix stale @return Javadoc on Typed.getAt to reflect error-based behavior#224
Splatcrafter merged 2 commits intobugfix/117-118-119-120-121-122-123-api-bugfixesfrom
copilot/sub-pr-223

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 21, 2026

The @return Javadoc on Typed.getAt(DynamicOps, Finder) stated the result may contain null when not found, but the implementation returns DataResult.error(...) in that case.

Changes

  • Typed.java: Updated @return doc to state the method returns an error DataResult when the path is not found, rather than a null-containing result.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copy link
Copy Markdown
Author

Copilot AI commented Mar 21, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • checkstyle.org
    • Triggering command: /opt/hostedtoolcache/CodeQL/2.24.3/x64/codeql/tools/linux64/java/bin/java /opt/hostedtoolcache/CodeQL/2.24.3/x64/codeql/tools/linux64/java/bin/java -jar /opt/hostedtoolcache/CodeQL/2.24.3/x64/codeql/xml/tools/xml-extractor.jar --fileList=/tmp/codeql-scratch-61acb3fe8481cff2/dbs/java/working/files-to-index17326435238323715136.list --sourceArchiveDir=/tmp/codeql-scratch-61acb3fe8481cff2/dbs/java/src --outputDir=/tmp/codeql-scratch-61acb3fe8481cff2/dbs/java/trap/java (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] [WIP] Address feedback on unused methods and core functionality improvements Fix stale @return Javadoc on Typed.getAt to reflect error-based behavior Mar 21, 2026
Copilot AI requested a review from Splatcrafter March 21, 2026 15:31
@Splatcrafter Splatcrafter marked this pull request as ready for review March 21, 2026 15:33
@Splatcrafter Splatcrafter requested a review from a team as a code owner March 21, 2026 15:33
@Splatcrafter Splatcrafter merged commit 47db958 into bugfix/117-118-119-120-121-122-123-api-bugfixes Mar 21, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants