Skip to content

Refactor and optimize validation logic for improved error handling#252

Merged
Splatcrafter merged 4 commits intodevelopfrom
bugfix/166-167-171-173-177-179-180-181-182-183-184-186-testkit-and-schematools-fixes
Apr 4, 2026
Merged

Refactor and optimize validation logic for improved error handling#252
Splatcrafter merged 4 commits intodevelopfrom
bugfix/166-167-171-173-177-179-180-181-182-183-184-186-testkit-and-schematools-fixes

Conversation

@Splatcrafter
Copy link
Copy Markdown
Member

Summary

This pull request refactors and optimizes validation and assertion logic across multiple components to enhance error handling, improve message clarity, and simplify logic. Changes were made to DynamicAssert, StructureValidator, DataFixTester, SchemaValidator, SchemaTester, and DataResultAssert.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Documentation
  • Build / CI

Related Issues

Closes #166, #167, #171, #173, #177, #179, #180, #181, #182, #183, #184, #186

Changes

  • Refactored validation and assertion logic in DynamicAssert, StructureValidator, and DataFixTester.
  • Dynamically determined max schema version in SchemaValidator and improved error handling with orElseThrow.
  • Improved the clarity and accuracy of error messages in DataResultAssert and SchemaTester.
  • Simplified validation rules and conditional logic.
  • Fixed placeholder replacement logic in messages.

Verification

  • Unit tests added/updated
  • Existing tests pass
  • Manual verification performed (if applicable)

Breaking Changes

None expected.

Checklist

  • Code follows project conventions
  • Public APIs are documented
  • Tests cover new behavior
  • No unnecessary dependencies added

…n and enforce stricter error handling with `orElseThrow` usage.
… message clarity across `DynamicAssert`, `StructureValidator`, and `DataFixTester`.
@Splatcrafter Splatcrafter self-assigned this Apr 4, 2026
@Splatcrafter Splatcrafter added bug Something isn't working refactor Internal code cleanup without changing external behavior (readability, structure, maintainability) labels Apr 4, 2026
@Splatcrafter Splatcrafter requested a review from a team as a code owner April 4, 2026 22:29
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see issue 997.

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 2e37c91.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@Splatcrafter Splatcrafter merged commit b2f151b into develop Apr 4, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working refactor Internal code cleanup without changing external behavior (readability, structure, maintainability)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant