Fix DFNR model not found when installed outside build tree#1003
Merged
Conversation
findModelPath() only searched relative to the executable directory, which fails when the binary is installed to a system location (e.g. /usr/local/bin). Add XDG data dir and system-wide search paths (/usr/share/AetherSDR, /usr/local/share/AetherSDR), add a CMake install() rule for the model file, and log all searched paths on failure for easier debugging. Fixes aethersdr#990 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
aethersdr-agent Bot
pushed a commit
that referenced
this pull request
Apr 10, 2026
…1003) findModelPath() only searched relative to the executable directory, which fails when the binary is installed to a system location (e.g. /usr/local/bin). Add XDG data dir and system-wide search paths (/usr/share/AetherSDR, /usr/local/share/AetherSDR), add a CMake install() rule for the model file, and log all searched paths on failure for easier debugging. Fixes #990 Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.local/share/AetherSDR/,/usr/share/AetherSDR/,/usr/local/share/AetherSDR/) tofindModelPath()so DFNR works when the binary is installed to a system locationinstall()rule for the model file on Linux/Windows socmake --installdeploys it correctlyTest plan
DeepFilterFilter: initialized, frame size = 480)cmake --installplaces model in correct locationFixes #990
JJ Boyd ~KG4VCF
Co-Authored with Claude Code
🤖 Generated with Claude Code