Fix RADE status label not appearing after mode selection#1049
Merged
Conversation
syncChanged is only emitted from feedRxAudio(), which requires DAX audio to be flowing on the RADE slice's DAX channel. On activation the label became visible but showed no text — appearing as if RADE wasn't working. Call setRadeSynced(false) immediately after setRadeActive(true) so the label shows "RADE ○ ---" from the moment RADE is selected, before any received signal arrives. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
spectrum()->vfoWidget() returns m_vfoWidget, an alias set by setActiveVfoWidget(). This alias is null until explicitly set, so activateRADE/deactivateRADE were silently skipping the label update on every invocation. vfoWidget(sliceId) looks up by slice ID and always returns the correct widget. Also fix deactivateRADE() which was reading m_radeSliceId after it had already been reset to -1. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
aethersdr-agent Bot
pushed a commit
that referenced
this pull request
Apr 10, 2026
* Fix RADE status label blank after activation until DAX audio flows syncChanged is only emitted from feedRxAudio(), which requires DAX audio to be flowing on the RADE slice's DAX channel. On activation the label became visible but showed no text — appearing as if RADE wasn't working. Call setRadeSynced(false) immediately after setRadeActive(true) so the label shows "RADE ○ ---" from the moment RADE is selected, before any received signal arrives. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Debug: log vfoWidget pointer in activateRADE * Fix RADE status label not appearing — use vfoWidget(sliceId) not alias spectrum()->vfoWidget() returns m_vfoWidget, an alias set by setActiveVfoWidget(). This alias is null until explicitly set, so activateRADE/deactivateRADE were silently skipping the label update on every invocation. vfoWidget(sliceId) looks up by slice ID and always returns the correct widget. Also fix deactivateRADE() which was reading m_radeSliceId after it had already been reset to -1. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
activateRADE()anddeactivateRADE()both usedspectrum()->vfoWidget()(no-arg), which returnsm_vfoWidget— an alias maintained bysetActiveVfoWidget(). This alias is only set when the user switches between slices. In the most common case — a single-slice session —setActiveVfoWidget()is never called because there is no slice-switch event to trigger it, som_vfoWidgetremains null for the entire session. Both functions were silently skipping all label updates via a null pointer guard.Confirmed via debug logging:
vfoWidget(sliceId)looks up by slice ID in them_vfoWidgetsmap and always returns the correct widget regardless of whether a slice switch has occurred.Changes
activateRADE(): usesw->vfoWidget(sliceId)instead ofsw->vfoWidget(); callsetRadeSynced(false)immediately aftersetRadeActive(true)so the label shows "RADE ○ ---" before any DAX audio arrives (previouslysyncChangedwould only fire oncefeedRxAudio()ran, requiring an active received signal)deactivateRADE(): same fix, and also moved thesetRadeActive(false)call beforem_radeSliceId = -1since the slice ID was already cleared by the time the old lookup ranTest plan
🤖 Generated with Claude Code