[#255] Clean up remaining Phase 0 acceptance items#270
Merged
Conversation
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## dev #270 +/- ##
=======================================
Coverage 68.57% 68.57%
=======================================
Files 1109 1110 +1
Lines 78030 78074 +44
Branches 10213 10221 +8
=======================================
+ Hits 53508 53543 +35
- Misses 20614 20619 +5
- Partials 3908 3912 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #255
Summary
This PR finishes the acceptance cleanup that remained after the original Phase 0 landing.
It adds the missing framework-level
AuthContextcontract next toICredentialProvider, and it records the honest Phase 0 provider-validation result for the current repo state: Kafka is the only durable backend validated in-repo today, while EventHubs remains a documented fallback / future validation item rather than an implied pass.What changed
AuthPrincipal+AuthContextunderAevatar.Foundation.Abstractions/Credentials0010-channel-phase0-provider-validation.mddocumenting the current provider-validation outcome and fallback stancedocs/README.mdand updated the abstractions README to expose the new credentials contractWhy
#255already hadDeleteAsync,ICredentialProvider, andcredential_refscaffold merged ondev, but the acceptance still was not clean because:AuthContexttypeThis PR closes both gaps without pretending EventHubs has been validated when the repository still ships Kafka-only durable backend support.
Validation
dotnet test test/Aevatar.Foundation.Abstractions.Tests/Aevatar.Foundation.Abstractions.Tests.csproj --nologobash tools/docs/build-index.shbash tools/docs/lint.shbash tools/ci/test_stability_guards.shdotnet test test/Aevatar.Foundation.Runtime.Hosting.Tests/Aevatar.Foundation.Runtime.Hosting.Tests.csproj --filter KafkaPersistentStreamProviderRedeliveryValidationTests --nologoNotes:
NU1507multi-package-source warnings unrelated to this changeDocs
docs/decisions/0010-channel-phase0-provider-validation.mddocs/README.mdviatools/docs/build-index.sh