Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## dev #419 +/- ##
==========================================
- Coverage 70.38% 70.37% -0.01%
==========================================
Files 1175 1175
Lines 84453 84453
Branches 11124 11124
==========================================
- Hits 59440 59438 -2
- Misses 20721 20723 +2
Partials 4292 4292
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This was referenced Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and solution
Fixes #416.
Lark schema 2.0 interactive cards require renderable card blocks under
body.elements. The standardLarkMessageComposerinteractive-card path still emittedelementsat the root, producing a hybrid v1/v2 payload that NyxID forwards to Lark and can fail with a 502 for/agentsand other card-only replies.This PR changes the standard interactive-card branch to emit
body.elements, matching the existing form-mode branch and Lark v2 shape.Impact paths
agents/platforms/Aevatar.GAgents.Platform.Lark/LarkMessageComposer.cstest/Aevatar.GAgents.Platform.Lark.Tests/LarkMessageComposerTests.csNyxID cross-check
Checked the local NyxID repository at
~/Code/NyxID:backend/src/services/channel_adapters/lark.rspassesreply.metadata.cardthrough as the interactive Larkcontentstring.contentto/open-apis/im/v1/messageswithmsg_type = "interactive".elementsshape, so this repository needs to produce the valid Lark v2body.elementspayload before handing it to NyxID.No NyxID code change is included in this PR; the issue's timeout/schema-validation hardening remains a separate defense-in-depth follow-up.
Validation
dotnet test test/Aevatar.GAgents.Platform.Lark.Tests/Aevatar.GAgents.Platform.Lark.Tests.csproj --nologo- passed, 13 testsdotnet test test/Aevatar.GAgents.ChannelRuntime.Tests/Aevatar.GAgents.ChannelRuntime.Tests.csproj --nologo- passed, 421 testsbash tools/ci/test_stability_guards.sh- passedgit diff --check- passedDocs
No architecture or user-facing documentation changes were needed.