Skip to content

Stabilize Elasticsearch projection index mappings#665

Merged
potter-sun merged 2 commits into
devfrom
pr-657-review-fix
May 18, 2026
Merged

Stabilize Elasticsearch projection index mappings#665
potter-sun merged 2 commits into
devfrom
pr-657-review-fix

Conversation

@louis4li
Copy link
Copy Markdown
Contributor

@louis4li louis4li commented May 18, 2026

Summary

  • Add descriptor-driven Elasticsearch projection mapping augmentation for timestamp and stable identifier fields.
  • Preserve explicit provider mappings while skipping open protobuf payload fields.
  • Update focused tests and provider docs for the new index mapping/rebuild contract.

Test plan

  • git diff --check
  • dotnet test test/Aevatar.CQRS.Projection.Core.Tests/Aevatar.CQRS.Projection.Core.Tests.csproj --nologo --filter ElasticsearchProjectionDocumentStoreBehaviorTests
  • dotnet test test/Aevatar.GAgentService.Tests/Aevatar.GAgentService.Tests.csproj --nologo --filter ServiceProjectionInfrastructureTests
  • dotnet test test/Aevatar.Scripting.Core.Tests/Aevatar.Scripting.Core.Tests.csproj --nologo --filter ScriptingProjectWiringTests

Note: mapping changes are not backward-compatible with old Elasticsearch projection indexes; clear or rebuild affected projection indexes.

🤖 Generated with Claude Code

Fixes #533

Generate low-risk descriptor-driven mappings at index bootstrap so read models no longer depend on dynamic inference for timestamp and identifier fields.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.31%. Comparing base (12f4ede) to head (aa71229).
⚠️ Report is 3 commits behind head on dev.

@@           Coverage Diff           @@
##              dev     #665   +/-   ##
=======================================
  Coverage   82.30%   82.31%           
=======================================
  Files         932      932           
  Lines       59485    59483    -2     
  Branches     7805     7805           
=======================================
+ Hits        48960    48961    +1     
+ Misses       7162     7161    -1     
+ Partials     3363     3361    -2     
Flag Coverage Δ
ci 82.31% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...data/ScriptCatalogEntryDocumentMetadataProvider.cs 100.00% <ø> (ø)
...etadata/ServiceCatalogReadModelMetadataProvider.cs 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

# Conflicts:
#	test/Aevatar.GAgentService.Tests/Projection/ServiceProjectionInfrastructureTests.cs
@potter-sun potter-sun changed the base branch from fix/2026-05-14_gagent-durable-terminal-completion to dev May 18, 2026 09:13
@potter-sun potter-sun marked this pull request as ready for review May 18, 2026 09:28
@potter-sun potter-sun merged commit 96720dd into dev May 18, 2026
13 checks passed
@potter-sun potter-sun deleted the pr-657-review-fix branch May 18, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standardize Elasticsearch projection index mappings for stable read model fields

2 participants